Skip to content

Conversation

@joniredis
Copy link
Contributor

@cmilesb suggestion to add viewer (read-only) role support to the cloud API.

@cmilesb suggestion to add viewer (read-only) role support to the cloud API.
@joniredis joniredis requested a review from cmilesb October 29, 2024 12:13
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joniredis - Looks good to me. Could you sign the CLA (see comment from CLAassistant, above) so I can merge it in?

@cmilesb cmilesb requested a review from a team October 29, 2024 14:53
@cmilesb cmilesb self-assigned this Oct 29, 2024
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joniredis
Copy link
Contributor Author

@cmilesb are you aware of any other places that should be updated? Sometime soon we will also release a logs viewer role for API that only allow such users to read the service logs through the API. That role will be good to assign to service that ingest logs to a logs repo (e.g. Splunk, Elastic, etc). We'll need to update the docs to reflect those as well by then.

@cmilesb
Copy link
Contributor

cmilesb commented Oct 29, 2024

@joniredis I don't think there are other places that need to be changed for this specifically. When we do add the logs viewer role, I'll have to change this and maybe some of the examples? I have a bunch of tickets to add which roles can do what actions for both the API and for database management on the UI. The automatic CAPI docs may also help with this, which Paolo and I will be working on next quarter.

@cmilesb cmilesb merged commit ede0b4e into main Oct 30, 2024
5 checks passed
@cmilesb cmilesb deleted the Add-API-viewer-role branch October 30, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants